Skip to content

Commit c2f2291

Browse files
authored
Eliminate Mac Android Debug Engine shard (flutter#27980)
At one point, this shard built the Android Vulkan binaries, but during the migration to ci.yaml-based recipes, the gn and build steps for that build were accidentally removed. As such, this shard no longer builds anything. This was detected when a buildroot roll triggered a clobber build which caused the verify_exported.dart script to fail due to a missing 'out' directory, which caused several of us to wonder why we were: 1. Checking that we strip release binaries on a debug bot, and 2. Why we're checking that we strip release binaries before we actually build anything at all. It appears that we used to build android vulkan binaries, such as in steps 14-16 of Build 11130: * https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Android%20Debug%20Engine/11130/overview We migrated to ci.yaml-based infra in this commit: * https://flutter-review.googlesource.com/c/infra/+/15660 A no-op rebuild was triggered in commmit: * flutter/engine#27599 Which triggered the following buikld, Build 11131: * https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Android%20Debug%20Engine/11131/overview That build does not contain the gn or build steps for the Android Vulkan binaries. HOWEVER... we have no users actually using Android Vulkan binaries, so rather than update the build to fix this, we delete the shard altogether and save some CPU. This will be followed by a patch that removes the --enable-vulkan flag from gn and throughout our build.
1 parent f88aea6 commit c2f2291

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

.ci.yaml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -185,15 +185,6 @@ targets:
185185
timeout: 60
186186
scheduler: luci
187187

188-
- name: Mac Android Debug Engine
189-
recipe: engine
190-
properties:
191-
android_sdk_license: \n24333f8a63b6825ea9c5514f83c2829b004d1fee
192-
android_sdk_preview_license: \n84831b9409646a918e30573bab4c9c91346d8abd
193-
build_android_debug: "true"
194-
timeout: 60
195-
scheduler: luci
196-
197188
- name: Mac Host Engine
198189
recipe: engine
199190
properties:

0 commit comments

Comments
 (0)