Reverts "Use Gradle KTS in new Android app projects by default (flutter#154061)" (flutter#157194)

Reverts: flutter#154061
Initiated by: QuncCccccc
Reason for reverting: might be the reason that cause Framework tree to red
Original PR Author: bartekpacia

Reviewed By: {gmackall, reidbaker}

This change reverts the following previous change:
This PR resolves flutter#151166

Author: auto-submit[bot]

dev/devicelab/bin/tasks/engine_dependency_proxy_test.dart

@@ -29,17 +29,14 @@ Future<void> main() async {
     await runProjectTest((FlutterProject flutterProject) async {
       await inDirectory(path.join(flutterProject.rootPath, 'android'), () async {
         section('Insert gradle testing script');
-        final File buildFile = getAndroidBuildFile(path.join(flutterProject.rootPath, 'android'));
-        buildFile.writeAsStringSync(
+        final File build = File(path.join(
+          flutterProject.rootPath, 'android', 'app', 'build.gradle',
+        ));
+        build.writeAsStringSync(
           '''
-tasks.register("printEngineMavenUrl") {
+task printEngineMavenUrl() {
     doLast {
-        project.repositories.forEach { repo ->
-            if (repo.name == "maven") {
-                repo as MavenArtifactRepository
-                logger.quiet(repo.url.toString())
-            }
-        }
+        println project.repositories.find { it.name == 'maven' }.url
     }
 }
           ''',

dev/devicelab/lib/framework/apk_utils.dart

@@ -256,17 +256,18 @@ class FlutterProject {
   String get rootPath => path.join(parent.path, name);
   String get androidPath => path.join(rootPath, 'android');
   String get iosPath => path.join(rootPath, 'ios');
-  File get appBuildFile => getAndroidBuildFile(androidPath);
 
   Future<void> addCustomBuildType(String name, {required String initWith}) async {
-    final File buildScript = appBuildFile;
+    final File buildScript = File(
+      path.join(androidPath, 'app', 'build.gradle'),
+    );
 
     buildScript.openWrite(mode: FileMode.append).write('''
 
 android {
     buildTypes {
-        create("$name") {
-            initWith(getByName("$initWith"))
+        $name {
+            initWith $initWith
         }
     }
 }
@@ -287,12 +288,14 @@ android {
   }
 
   Future<void> setMinSdkVersion(int sdkVersion) async {
-    final File buildScript = appBuildFile;
+    final File buildScript = File(
+      path.join(androidPath, 'app', 'build.gradle'),
+    );
 
     buildScript.openWrite(mode: FileMode.append).write('''
 android {
     defaultConfig {
-        minSdk = $sdkVersion
+        minSdkVersion $sdkVersion
     }
 }
     ''');
@@ -305,20 +308,22 @@ android {
   }
 
   Future<void> addProductFlavors(Iterable<String> flavors) async {
-    final File buildScript = appBuildFile;
+    final File buildScript = File(
+      path.join(androidPath, 'app', 'build.gradle'),
+    );
 
     final String flavorConfig = flavors.map((String name) {
       return '''
-create("$name") {
-    applicationIdSuffix = ".$name"
-    versionNameSuffix = "-$name"
+$name {
+    applicationIdSuffix ".$name"
+    versionNameSuffix "-$name"
 }
       ''';
     }).join('\n');
 
     buildScript.openWrite(mode: FileMode.append).write('''
 android {
-    flavorDimensions.add("mode")
+    flavorDimensions "mode"
     productFlavors {
         $flavorConfig
     }
@@ -327,7 +332,9 @@ android {
   }
 
   Future<void> introduceError() async {
-    final File buildScript = appBuildFile;
+    final File buildScript = File(
+      path.join(androidPath, 'app', 'build.gradle'),
+    );
     await buildScript.writeAsString((await buildScript.readAsString()).replaceAll('buildTypes', 'builTypes'));
   }
 
@@ -470,14 +477,3 @@ String? validateSnapshotDependency(FlutterProject project, String expectedTarget
   return contentSnapshot.contains('$expectedTarget ')
     ? null : 'Dependency file should have $expectedTarget as target. Instead found $contentSnapshot';
 }
-
-File getAndroidBuildFile(String androidPath) {
-  final File groovyFile = File(path.join(androidPath, 'app', 'build.gradle'));
-  final File kotlinFile = File(path.join(androidPath, 'app', 'build.gradle.kts'));
-
-  if (groovyFile.existsSync()) {
-    return groovyFile;
-  }
-
-  return kotlinFile;
-}

packages/flutter_tools/lib/src/project.dart

@@ -467,19 +467,7 @@ class AndroidProject extends FlutterProjectPlatform {
   static final RegExp _androidNamespacePattern = RegExp('android {[\\S\\s]+namespace\\s*=?\\s*[\'"](.+)[\'"]');
   static final RegExp _applicationIdPattern = RegExp('^\\s*applicationId\\s*=?\\s*[\'"](.*)[\'"]\\s*\$');
   static final RegExp _imperativeKotlinPluginPattern = RegExp('^\\s*apply plugin\\:\\s+[\'"]kotlin-android[\'"]\\s*\$');
-
-  /// Examples of strings that this regex matches:
-  /// - `id "kotlin-android"`
-  /// - `id("kotlin-android")`
-  /// - `id ( "kotlin-android" ) `
-  /// - `id "org.jetbrains.kotlin.android"`
-  /// - `id("org.jetbrains.kotlin.android")`
-  /// - `id ( "org.jetbrains.kotlin.android" )`
-  static final List<RegExp> _declarativeKotlinPluginPatterns = <RegExp>[
-      RegExp('^\\s*id\\s*\\(?\\s*[\'"]kotlin-android[\'"]\\s*\\)?\\s*\$'),
-      RegExp('^\\s*id\\s*\\(?\\s*[\'"]org.jetbrains.kotlin.android[\'"]\\s*\\)?\\s*\$'),
-  ];
-
+  static final RegExp _declarativeKotlinPluginPattern = RegExp('^\\s*id\\s+[\'"]kotlin-android[\'"]\\s*\$');
 
   /// Pattern used to find the assignment of the "group" property in Gradle.
   /// Expected example: `group "dev.flutter.plugin"`
@@ -575,9 +563,7 @@ class AndroidProject extends FlutterProjectPlatform {
   /// True, if the app project is using Kotlin.
   bool get isKotlin {
     final bool imperativeMatch = firstMatchInFile(appGradleFile, _imperativeKotlinPluginPattern) != null;
-    final bool declarativeMatch = _declarativeKotlinPluginPatterns.any((RegExp pattern) {
-      return (firstMatchInFile(appGradleFile, pattern) != null);
-    });
+    final bool declarativeMatch = firstMatchInFile(appGradleFile, _declarativeKotlinPluginPattern) != null;
     return imperativeMatch || declarativeMatch;
   }
 

packages/flutter_tools/templates/app_shared/android-java.tmpl/app/build.gradle.kts.tmpl renamed to packages/flutter_tools/templates/app_shared/android-java.tmpl/app/build.gradle.tmpl

@@ -1,8 +1,8 @@
 plugins {
-    id("com.android.application")
-    id("kotlin-android")
+    id "com.android.application"
+    id "kotlin-android"
     // The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugins.
-    id("dev.flutter.flutter-gradle-plugin")
+    id "dev.flutter.flutter-gradle-plugin"
 }
 
 android {
@@ -16,7 +16,7 @@ android {
     }
 
     kotlinOptions {
-        jvmTarget = JavaVersion.VERSION_1_8.toString()
+        jvmTarget = JavaVersion.VERSION_1_8
     }
 
     defaultConfig {
@@ -34,7 +34,7 @@ android {
         release {
             // TODO: Add your own signing config for the release build.
             // Signing with the debug keys for now, so `flutter run --release` works.
-            signingConfig = signingConfigs.getByName("debug")
+            signingConfig = signingConfigs.debug
         }
     }
 }

packages/flutter_tools/templates/app_shared/android-java.tmpl/build.gradle.kts.tmpl

@@ -0,0 +1,18 @@
+allprojects {
+    repositories {
+        google()
+        mavenCentral()
+    }
+}
+
+rootProject.buildDir = "../build"
+subprojects {
+    project.buildDir = "${rootProject.buildDir}/${project.name}"
+}
+subprojects {
+    project.evaluationDependsOn(":app")
+}
+
+tasks.register("clean", Delete) {
+    delete rootProject.buildDir
+}

packages/flutter_tools/templates/app_shared/android-java.tmpl/build.gradle.tmpl

@@ -1,8 +1,8 @@
 plugins {
-    id("com.android.application")
-    id("kotlin-android")
+    id "com.android.application"
+    id "kotlin-android"
     // The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugins.
-    id("dev.flutter.flutter-gradle-plugin")
+    id "dev.flutter.flutter-gradle-plugin"
 }
 
 android {
@@ -16,7 +16,7 @@ android {
     }
 
     kotlinOptions {
-        jvmTarget = JavaVersion.VERSION_1_8.toString()
+        jvmTarget = JavaVersion.VERSION_1_8
     }
 
     defaultConfig {
@@ -34,7 +34,7 @@ android {
         release {
             // TODO: Add your own signing config for the release build.
             // Signing with the debug keys for now, so `flutter run --release` works.
-            signingConfig = signingConfigs.getByName("debug")
+            signingConfig = signingConfigs.debug
         }
     }
 }

packages/flutter_tools/templates/app_shared/android-kotlin.tmpl/app/build.gradle.kts.tmpl renamed to packages/flutter_tools/templates/app_shared/android-kotlin.tmpl/app/build.gradle.tmpl

@@ -0,0 +1,18 @@
+allprojects {
+    repositories {
+        google()
+        mavenCentral()
+    }
+}
+
+rootProject.buildDir = "../build"
+subprojects {
+    project.buildDir = "${rootProject.buildDir}/${project.name}"
+}
+subprojects {
+    project.evaluationDependsOn(":app")
+}
+
+tasks.register("clean", Delete) {
+    delete rootProject.buildDir
+}