Skip to content

Commit 3ee9e3d

Browse files
author
Nurhan Turgut
authored
[web] changing the integration tests to show errors (flutter#17364)
* changing the integration tests to show errors. The drive file is reduced to nothing now * adding more to readme * rebase to master and removing unused import * changing readme
1 parent 91ccdbe commit 3ee9e3d

File tree

5 files changed

+15
-32
lines changed

5 files changed

+15
-32
lines changed

e2etests/web/regular_integration_tests/README.md

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,18 @@ configuration (e.g. PWA vs non-PWA packaging), please create another
55
directory under e2etests/web. Otherwise tests such as text_editing, history,
66
scrolling, pointer events... should all go under this package.
77
8-
# To run the application under test for traouble shooting purposes.
8+
Tests can be run on both 'release' and 'profile' modes. However 'release' mode
9+
will shorten the error. Use 'profile' mode for trouble-shooting purposes where
10+
you can also see the full stack trace.
11+
12+
# To run the application under test for trouble shooting purposes.
913
flutter run -d web-server lib/text_editing_main.dart --local-engine=host_debug_unopt
1014
1115
# To run the Text Editing test and use the developer tools in the browser.
12-
flutter run --target=test_driver/text_editing_e2e.dart -d web-server --web-port=8080 --release --local-engine=host_debug_unopt
16+
flutter run --target=test_driver/text_editing_e2e.dart -d web-server --web-port=8080 --profile --local-engine=host_debug_unopt
17+
18+
# To test the Text Editing test with driver you either of the following:
19+
flutter drive -v --target=test_driver/text_editing_e2e.dart -d web-server --profile --browser-name=chrome --local-engine=host_debug_unopt
1320
14-
# To test the Text Editing test with driver:
1521
flutter drive -v --target=test_driver/text_editing_e2e.dart -d web-server --release --browser-name=chrome --local-engine=host_debug_unopt
1622
```

e2etests/web/regular_integration_tests/pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ dev_dependencies:
1313
sdk: flutter
1414
flutter_test:
1515
sdk: flutter
16-
e2e: 0.2.4+4
16+
e2e: 0.4.0
1717
http: 0.12.0+2
1818
test: any
1919

2020
flutter:
2121
assets:
22-
- assets/images/
22+
- assets/images/

e2etests/web/regular_integration_tests/test_driver/image_loading_e2e.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
// found in the LICENSE file.
44

55
import 'dart:html' as html;
6-
import 'package:flutter/widgets.dart';
76
import 'package:flutter_test/flutter_test.dart';
87
import 'package:regular_integration_tests/image_loading_main.dart' as app;
98

e2etests/web/regular_integration_tests/test_driver/image_loading_e2e_test.dart

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,6 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
import 'dart:io';
5+
import 'package:e2e/e2e_driver.dart' as e2e;
66

7-
import 'package:flutter_driver/flutter_driver.dart';
8-
9-
Future<void> main() async {
10-
final FlutterDriver driver = await FlutterDriver.connect();
11-
12-
final String dataRequest =
13-
await driver.requestData(null, timeout: const Duration(seconds: 1));
14-
await driver.close();
15-
16-
exit(dataRequest == 'pass' ? 0 : 1);
17-
}
7+
Future<void> main() async => e2e.main();

e2etests/web/regular_integration_tests/test_driver/text_editing_e2e_test.dart

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,6 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
import 'dart:io';
5+
import 'package:e2e/e2e_driver.dart' as e2e;
66

7-
import 'package:flutter_driver/flutter_driver.dart';
8-
9-
Future<void> main() async {
10-
final FlutterDriver driver = await FlutterDriver.connect();
11-
12-
// TODO(nurhan): https://github.com/flutter/flutter/issues/51940
13-
final String dataRequest =
14-
await driver.requestData(null, timeout: const Duration(seconds: 1));
15-
print('result $dataRequest');
16-
await driver.close();
17-
18-
exit(dataRequest == 'pass' ? 0 : 1);
19-
}
7+
Future<void> main() async => e2e.main();

0 commit comments

Comments
 (0)