Better message when a side module needs exceptions #9698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns. If a side module wants exceptions, the main module must be built to support that. Helps #9691
Member
Author
|
review ping @sbc100 |
sbc100
approved these changes
Nov 6, 2019
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
The tests seems rather long.. but I don't remember if we have helpers to make that kind of things easier to test.
Member
Author
|
Yeah, not sure there's a shorter way. We don't have many such tests in other. @sbc100 did you see my question in the PR title about EXPORT_ALL? |
Collaborator
|
I wasn't aware of any differences between EXPORT_ALL with llvm backend vs fastcomp? or are you seeing the same issue with fastcomp? |
Member
Author
|
It doesn't look related to the backend, same on fastcomp. I investigated a bit more and opened #9793 |
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
) The main module needs to be built with exceptions support for a side module to use it, both for system libs and for the current JS support. This informs users they need to do that if a side module throws and the main wasn't built properly to support that. Helps emscripten-core#9691
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main module needs to be built with exceptions support for a side module to use it, both for system libs and for the current JS support. This informs users they need to do that if a side module throws and the main wasn't built properly to support that.
Helps #9691
Btw @sbc100 I noticed while writing this patch that
EXPORT_ALLis needed for main module to add the JS glue code to where it can be imported from side modules. I was surprised we don't enable that flag by default, maybe I'm missing something?