From 204d3daadd1ebf2a8ab1d84992497d7032c25016 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jukka=20Jyl=C3=A4nki?= Date: Thu, 23 Oct 2025 00:01:12 +0300 Subject: [PATCH] Skip other.test_pthread_growth test on Windows on ARM if Node.js is 22.16.0. See https://github.com/emscripten-core/emscripten/issues/25627 --- test/test_other.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/test/test_other.py b/test/test_other.py index ddcd572e56a23..e2185657ede48 100644 --- a/test/test_other.py +++ b/test/test_other.py @@ -11,6 +11,7 @@ import json import locale import os +import platform import random import re import select @@ -12987,6 +12988,11 @@ def test_growable_arraybuffers(self): 'minimal': (['-sMINIMAL_RUNTIME', '-sMODULARIZE', '-sEXPORT_NAME=MyModule'],), }) def test_pthread_growth(self, cflags, pthread_pool_size = 1): + if WINDOWS and platform.machine() == 'ARM64': + # https://github.com/emscripten-core/emscripten/issues/25627 + # TODO: Switch this to a "require Node.js 24" check + self.require_node_canary() + self.set_setting('PTHREAD_POOL_SIZE', pthread_pool_size) if '-sGROWABLE_ARRAYBUFFERS' in cflags: self.node_args.append('--experimental-wasm-rab-integration')