Support separate version of Node.js for running tests. NFC #20573
Conversation
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
lgtm % please add some comments to tools/config_template.py where we document the config file options, to mention this new option.
sbc100
force-pushed
the
node_js_test
branch
2 times, most recently
from
1881b28 to
2477531
Compare
|
I might've missed some conversation, I thought in #20551 in the last thread you said we wouldn't test those older Node versions? |
I decided it would be cleaner to allow the testing to remain unchanged, at least for now. That way we can't decided if/when to stop testing on older node versions as a separate concern. I think being able to configure the internal version of node separately to target version under test is a useful feature either way. For example, I often want to switch the version of node on which I run tests.. but don't want that to interact with the compiler itself. |
sbc100
force-pushed
the
node_js_test
branch
2 times, most recently
from
bb9c4ce to
db7c53e
Compare
This is needed for emscripten-core#20551 so that we can continue to run tests under versions of node that are too old to run the compiler.
|
Sounds reasonable. |
…n-core#20573) This is needed for emscripten-core#20551 so that we can continue to run tests under versions of node that are too old to run the compiler.
3 participants
This is needed for #20551 so that we can continue to run tests under versions of node that are too old to run the compiler.