Skip to content

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Jun 30, 2023

This change verifies that closure can successfully lower the optional chaining away on older browsers.

This also requires bumping of chrome and safari minimum versions.. so maybe its not worth it?

@sbc100
Copy link
Collaborator Author

sbc100 commented Jun 30, 2023

I'm not sure if the value we will get out of this is worth the min version bump.. but maybe those two versions are fine to bump anyway since they are both evergreen browsers?

@juj @dschuff @kripken ?

@sbc100 sbc100 force-pushed the allow_optional_chaining branch from 5aefa95 to 64b3817 Compare June 30, 2023 23:26
@kripken
Copy link
Member

kripken commented Jun 30, 2023

The version bumps don't trouble me much, yeah, they look minor. But do you have a sense for the possible benefit here? If this is a common pattern in our JS code that might be nice, but offhand I can't think of places that would benefit.

@sbc100
Copy link
Collaborator Author

sbc100 commented Jun 30, 2023

Yeah, I'm struggling to see where would save a lot by using this.. its kind of hard to search for possible places where it might apply but I'll give it a go.

@juj
Copy link
Collaborator

juj commented Jul 1, 2023

LGTM, the browser version bumps look fine. Unity currently requires Firefox 78.9.0esr as minimum, and soon will bump to Firefox 100-something esr because older versions had a bug with multithreading.

I think it would make sense to group ?., ??, and ??= operators behind the same feature item. Looking at min versions, all other browsers added support in the same version, except for Firefox, where there was a two version gap. To accommodate for that, we can just take the newer Firefox 74 as the min version.

Screen Shot 2023-07-01 at 12 03 07 PM

This change verifies that closure can successfully lower the optional
chaining away on older browsers.

This also requires bumping of chrome and safari minimum versions.. so
maybe its not worth it?
@sbc100
Copy link
Collaborator Author

sbc100 commented Nov 9, 2023

Superseded by #20549

@sbc100 sbc100 closed this Nov 9, 2023
@sbc100 sbc100 deleted the allow_optional_chaining branch November 9, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants