Remove custom alarm impl in favor of lower level itimer API
#18416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
getitimer
branch
9 times, most recently
from
b2984c9 to
6c3ee4e
Compare
sbc100
changed the title
alarm impl in favor of lower level itimer syscallsalarm impl in favor of lower level itimer API
Collaborator
Author
|
gentle ping.. |
kripken
reviewed
Jan 6, 2023
sbc100
force-pushed
the
getitimer
branch
2 times, most recently
from
b2f724c to
ab7ae19
Compare
kripken
reviewed
Jan 9, 2023
sbc100
force-pushed
the
getitimer
branch
2 times, most recently
from
ddd211c to
d23c1c8
Compare
kripken
reviewed
Jan 10, 2023
kripken
reviewed
Jan 11, 2023
sbc100
force-pushed
the
getitimer
branch
3 times, most recently
from
597932d to
4b16914
Compare
kripken
reviewed
Jan 12, 2023
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
lgtm aside from testing questions.
Sorry for the long review here!
These alarms/signals will now fire if when waiting on a lock (i.e. they don't depend on the event loops running). Fixes: #12415
Collaborator
Author
|
We can adjust |
kripken
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These alarms/signals will now fire if when waiting on a lock (i.e. they don't depend on the event loops running).
Fixes: #12415