Skip to content

Commit b313178

Browse files
authored
Make test_dash_s_list_parsing more robust (#18336)
Don't try to assert that the emcc stderr is empty. The compiler can generate message on stderr under certain circumstances. For example the `cache:INFO: generating system library: ...` messages. Without this change this test fails if the cache is cleared right before running it.
1 parent 005bb5b commit b313178

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

test/test_other.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9208,8 +9208,7 @@ def test_dash_s_list_parsing(self):
92089208
proc = self.run_process([EMCC, 'src.c', '-s', export_arg], stdout=PIPE, stderr=PIPE, check=not expected)
92099209
print(proc.stderr)
92109210
if not expected:
9211-
self.assertFalse(proc.stderr)
9212-
js = open('a.out.js').read()
9211+
js = read_file('a.out.js')
92139212
for sym in ('_a', '_b', '_c', '_d'):
92149213
self.assertContained(f'var {sym} = ', js)
92159214
else:

0 commit comments

Comments
 (0)