Skip to content

Commit ad50ab2

Browse files
committed
Update the minimum supported build-time version of node to 16.20.0
For the minimum build-time version of node we bump 10.19.0 -> 16.20.0 This new minimum version matches the version that we ship with emsdk. Critically it supports null coalescing & logical assignment needed by #20549.
1 parent 3014d63 commit ad50ab2

File tree

3 files changed

+13
-7
lines changed

3 files changed

+13
-7
lines changed

ChangeLog.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,11 @@ See docs/process.md for more on how version tagging works.
2020

2121
3.1.48 (in development)
2222
-----------------------
23+
- The minimum version of node required run the compiler was updated from
24+
10.19 to 16.20. The minimum verison of node supported by the
25+
emscripten-generated code was updated from 15.0 to 16.20. One side effect of
26+
this is that the `NODEJS_CATCH_REJECTION` settings is no longer relevant and
27+
is now ignored. (#20551)
2328
- A new top-level `bootstrap` script was added. This script is for emscripten
2429
developers and helps take a care of post-checkout tasks such as `npm install`.
2530
If this script needs to be run (e.g. becuase package.json was changed, emcc

test/test_sanity.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,8 +281,8 @@ def test_node(self):
281281
for version, succeed in [('v0.8.0', False),
282282
('v4.1.0', False),
283283
('v10.18.0', False),
284-
('v10.19.0', True),
285-
('v10.19.1-pre', True),
284+
('v16.20.0', True),
285+
('v16.20.1-pre', True),
286286
('cheez', False)]:
287287
print(version, succeed)
288288
delete_file(SANITY_FILE)

tools/shared.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,12 @@
5252
PRINT_SUBPROCS = int(os.getenv('EMCC_VERBOSE', '0'))
5353
SKIP_SUBPROCS = False
5454

55-
# Minimum node version required to run the emscripten compiler. This is distinct
56-
# from the minimum version required to execute the generated code. This is not an
57-
# exact requirement, but is the oldest version of node that we do any testing with.
58-
# This version aligns with the current Ubuuntu TLS 20.04 (Focal).
59-
MINIMUM_NODE_VERSION = (10, 19, 0)
55+
# Minimum node version required to run the emscripten compiler. This is
56+
# distinct from the minimum version required to execute the generated code
57+
# (settings.MIN_NODE_VERSION).
58+
# This version currently matches the node version that we ship with emsdk
59+
# which means that we can say for sure that this version is well supported.
60+
MINIMUM_NODE_VERSION = (16, 20, 0)
6061
EXPECTED_LLVM_VERSION = 18
6162

6263
# These get set by setup_temp_dirs

0 commit comments

Comments
 (0)