Skip to content

Commit a63dda8

Browse files
committed
Fix test_promise
It now needs version to be lowered from the default, not bumped.
1 parent 7eaf0a2 commit a63dda8

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

test/test_core.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9910,13 +9910,9 @@ def test_main_reads_args(self):
99109910
@requires_node
99119911
def test_promise(self):
99129912
# This test depends on Promise.any, which in turn requires a modern target. Check that it
9913-
# fails to even build without bumping the min versions:
9914-
err = self.expect_fail([EMCC, test_file('core/test_promise.c')])
9913+
# fails to even build on old targets.
9914+
err = self.expect_fail([EMCC, test_file('core/test_promise.c'), '-sMIN_CHROME_VERSION=75'])
99159915
self.assertContained('error: emscripten_promise_any used, but Promise.any is not supported by the current runtime configuration', err)
9916-
self.set_setting('MIN_NODE_VERSION', '150000')
9917-
self.set_setting('MIN_SAFARI_VERSION', '150000')
9918-
self.set_setting('MIN_FIREFOX_VERSION', '79')
9919-
self.set_setting('MIN_CHROME_VERSION', '85')
99209916
self.do_core_test('test_promise.c')
99219917

99229918
@with_asyncify_and_jspi

0 commit comments

Comments
 (0)