Skip to content

Commit 7e7beb8

Browse files
authored
Fix typo in transpile warning. NFC (#20813)
Also, give test-node-compat CI phases better names Helps with #20531
1 parent 9af9e58 commit 7e7beb8

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

.circleci/config.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -731,7 +731,7 @@ jobs:
731731
- install-emsdk
732732
- install-node-canary
733733
- run-tests:
734-
title: "selected subset"
734+
title: "node (canary)"
735735
test_targets: "
736736
other.test_deterministic
737737
other.test_gen_struct_info
@@ -747,7 +747,7 @@ jobs:
747747
- install-node-version:
748748
node_version: "10.19.0"
749749
- run-tests:
750-
title: "selected subset"
750+
title: "node (oldest / 10.19.0)"
751751
test_targets: "
752752
other.test_gen_struct_info
753753
other.test_native_call_before_init
@@ -761,7 +761,7 @@ jobs:
761761
- run-tests:
762762
# Run tests that on older versions of node would require flags, but
763763
# those flags should not be injected on newer versions.
764-
title: "selected subset"
764+
title: "node (latest)"
765765
test_targets: "-v
766766
other.test_gen_struct_info
767767
other.test_native_call_before_init

tools/link.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1142,7 +1142,7 @@ def phase_linker_setup(options, state, newargs):
11421142
settings.MIN_IE_VERSION != 0x7FFFFFFF)
11431143

11441144
if options.use_closure_compiler is None and settings.TRANSPILE_TO_ES5:
1145-
diagnostics.warning('transpile', 'enabling transpilation via closure due to browser version settings. This warning can be suppressed by passing `--closure=1` or `--closure=0` to opt into our explicitly.')
1145+
diagnostics.warning('transpile', 'enabling transpilation via closure due to browser version settings. This warning can be suppressed by passing `--closure=1` or `--closure=0` to opt into this explicitly.')
11461146

11471147
# https://caniuse.com/class: EDGE:13 FF:45 CHROME:49 SAFARI:9
11481148
supports_es6_classes = (settings.MIN_EDGE_VERSION >= 13 and

0 commit comments

Comments
 (0)