Skip to content

Commit 4e0543a

Browse files
authored
Remove old/unused warning from jsifier (#20298)
I'm fairly sure this no longer correct and doesn't fire in any of our test code. This warning only fires for library members that are of type 'string' for some reason (as of 1ddb637), and since library members with deps are almost universally functions I've never seen it fire.
1 parent 813a727 commit 4e0543a

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

src/jsifier.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -428,11 +428,9 @@ function(${args}) {
428428
const original = LibraryManager.library[symbol];
429429
let snippet = original;
430430

431+
// Check for dependencies on `__internal` symbols from user libraries.
431432
const isUserSymbol = LibraryManager.library[symbol + '__user'];
432433
deps.forEach((dep) => {
433-
if (typeof snippet == 'string' && !(dep in LibraryManager.library)) {
434-
warn(`missing library dependency ${dep}, make sure you are compiling with the right options (see #if in src/library*.js)`);
435-
}
436434
if (isUserSymbol && LibraryManager.library[dep + '__internal']) {
437435
warn(`user library symbol '${symbol}' depends on internal symbol '${dep}'`);
438436
}

0 commit comments

Comments
 (0)