Skip to content

Commit 373b282

Browse files
authored
When running tests with --save-dir use the local out/test directory (#18562)
In general this should be easier to find than hunting around in the system temp dir, and it won't conflict with other users on the same system also running tests with `--save-dir`.
1 parent 9de1f3e commit 373b282

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

site/source/docs/getting_started/test-suite.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ emits debug output and intermediate files (the files go in
198198
199199
200200
You can also specify ``--save-dir`` to save the temporary directory that the
201-
test runner uses into **/tmp/emscripten_test/**. This is a test suite-specific
201+
test runner uses into **/out/test/**. This is a test suite-specific
202202
feature, and is useful for inspecting test outputs as well as temporary files
203203
generated by the test. By default, the temporary directory will be cleaned
204204
between each test run, but you can add ``--no-clean`` to avoid this.

test/common.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -583,7 +583,7 @@ def setUp(self):
583583
self.temp_files_before_run.append(os.path.normpath(os.path.join(root, filename)))
584584

585585
if EMTEST_SAVE_DIR:
586-
self.working_dir = os.path.join(self.temp_dir, 'emscripten_test')
586+
self.working_dir = path_from_root('out/test')
587587
if os.path.exists(self.working_dir):
588588
if EMTEST_SAVE_DIR == 2:
589589
print('Not clearing existing test directory')

0 commit comments

Comments
 (0)