Skip to content

Commit 16528bf

Browse files
committed
mach: Fix cargo-geckolib check / cargo-geckolib build after servo#19476.
1 parent 5f4f355 commit 16528bf

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

python/servo/devenv_commands.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,11 @@
2929
@CommandProvider
3030
class MachCommands(CommandBase):
3131
def run_cargo(self, params, geckolib=False, check=False):
32+
if not params:
33+
params = []
34+
3235
if geckolib:
36+
params += ['-p', 'geckoservo']
3337
self.set_use_stable_rust()
3438
crate_dir = path.join('ports', 'geckolib')
3539
else:
@@ -39,9 +43,6 @@ def run_cargo(self, params, geckolib=False, check=False):
3943
self.ensure_clobbered()
4044
env = self.build_env(geckolib=geckolib)
4145

42-
if not params:
43-
params = []
44-
4546
if check:
4647
params = ['check'] + params
4748

@@ -94,7 +95,7 @@ def check(self, params):
9495
'params', default=None, nargs='...',
9596
help="Command-line arguments to be passed through to cargo check")
9697
def check_geckolib(self, params):
97-
return self.run_cargo(["-p", "geckoservo"] + (params or []), check=True, geckolib=True)
98+
return self.run_cargo(params, check=True, geckolib=True)
9899

99100
@Command('cargo-update',
100101
description='Same as update-cargo',

0 commit comments

Comments
 (0)