Skip to content

Commit 944c4cf

Browse files
Fix typos
Co-authored-by: Copilot <[email protected]>
1 parent 6877dce commit 944c4cf

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

guides/for_developers/fd_debugging.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -75,15 +75,15 @@ If both session negotiation and connection establishment went well, you can obse
7575
1. We heavily rely on chrome://webrtc-internals here.
7676
1. Check counters: packetsReceived, framesReceived, framesDecoded, framesDropped.
7777
1. E.g. if packetsReceived increases but framesReceived does not, it means that there is a problem in assembling video frames from RTP packets. This can happen when:
78-
1. web browser is not able to correctly demux incomming RTP streams possibly because sender uses incorrect payload type in RTP packets (different than the one announced in SDP) or does not include MID in RTP headers.
78+
1. web browser is not able to correctly demux incoming RTP streams possibly because sender uses incorrect payload type in RTP packets (different than the one announced in SDP) or does not include MID in RTP headers.
7979
Keep in mind that MID MAY be sent only at the beginning of the transmission to save bandwidth.
8080
This is enough to create a mapping between SSRC and MID on the receiver side.
8181
1. marker bit in RTP header is incorrectly set by the sender (although dependent on the codec, in case of video, marker bit is typically set when an RTP packet contains the end of a video frame)
8282
1. media is incorrectly packed into RTP packet payload because of bugs in RTP payloader
8383
1. E.g. if packetsReceived increases, framesReceived increases but framesDecoded does not, it probably means errors in decoding process.
8484
In this case, framesDropped will probably also increase.
8585
1. framesDropped may also increase when frames are assembled too late i.e. their playout time has passed.
86-
1. Check borwser logs.
86+
1. Check browser logs.
8787
Some of the errors (e.g. decoder errors) might be logged.
8888

8989
## QoE
@@ -93,22 +93,22 @@ Mostly because it very often depends on a lot of factors (network condition, har
9393
Problems with QoE are hard to reproduce, very often don't occur in local/office environment.
9494

9595
1. We heavily rely on chrome://webrtc-internals here.
96-
1. Check coutners: nackCount, retransmittedPacketsSent, packetsLost.
96+
1. Check counters: nackCount, retransmittedPacketsSent, packetsLost.
9797
Retransmissions (RTX) are must have.
9898
Without RTX, even 1% of packet loss will have very big impact on QoE.
9999
1. Check incoming/outgoing bitrate and its stability.
100-
1. Check jitterBufferDelay/jitterBufferEmittedCount_in_ms - this is avg time each video frame spends in jitter buffer before being emitted for plaout.
100+
1. Check jitterBufferDelay/jitterBufferEmittedCount_in_ms - this is avg time each video frame spends in jitter buffer before being emitted for playout.
101101
1. JitterBuffer is adjusted dynamically.
102102

103103
## Debugging in production
104104

105105
1. Dump WebRTC stats via getStats() into db for later analysis.
106106
1. getStats() can still be called after PC has failed or has been closed.
107-
1. Continous storage WebRTC stats as time series might be challenging.
107+
1. Continuous storage WebRTC stats as time series might be challenging.
108108
We don't have a lot of experience doing it.
109109
1. Come up with custom metrics that will allow you to observe the scale of a given problem or monitor how something changes in time.
110110
1. E.g. if you feel like you very often encounter ICE failures, count them and compare to successful workflows or to the number of complete and successful SDP offer/answer exchanges.
111-
This way you will see the scale of the problem and you can observer how it changes in time, after introducing fixes or new features.
111+
This way you will see the scale of the problem and you can observe how it changes in time, after introducing fixes or new features.
112112
1. It's important to look at numbers instead of specific cases as there will always be someone who needs to refresh the page, restart the connection etc.
113113
What matters is the ratio of such problems and how it changes in time.
114114
1. E.g. this is a quote from Sean DuBois working on WebRTC in OpenAI:

guides/for_developers/fd_encryption.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ In WebRTC this is a string "EXTRACTOR-dtls_srtp"
116116
```mermaid
117117
flowchart TD
118118
K["KeyingMaterial"] --> CM["ClientMasterKey"]
119-
K --> SM["ServertMasterKey"]
119+
K --> SM["ServerMasterKey"]
120120
K --> CS["ClientMasterSalt"]
121121
K --> SS["ServerMasterSalt"]
122122
```

0 commit comments

Comments
 (0)