[DOCS] Sync missing definitions from Elasticsearch glossary #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcawl
reviewed
Mar 29, 2019
lcawl
reviewed
Mar 29, 2019
| ifdef::elasticsearch-terms[] | ||
| [[glossary-query]] query :: | ||
|
|
||
| A query is the basic component of a search. A search can be defined by one or |
Contributor
There was a problem hiding this comment.
These feel more verbose than I'd expect for a glossary entry, but I guess it doesn't matter too much.
Contributor
Author
There was a problem hiding this comment.
Agree. I think a rewrite is probably in order. Query isn't actually defined here IMO.
I opened elastic/elasticsearch#40643 to address that separately. I'm planning on doing a general query overhaul shortly. That issue will likely be a part of that work effort.
lcawl
approved these changes
Mar 29, 2019
Contributor
lcawl
left a comment
lcawl
left a comment
There was a problem hiding this comment.
LGTM and builds successfully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few Elasticsearch definitions missing from the Stack Docs glossary:
Uncovered this while working on these issues: