From 4e6d66e28b0ad77276d641dc82acdce6cef73984 Mon Sep 17 00:00:00 2001
From: Tom Veasey <tveasey@elastic.co>
Date: Fri, 23 Mar 2018 16:54:05 +0000
Subject: [PATCH] Trap all remaining unguarded calls to create chi distribution
 with df == 0

---
 lib/maths/CPeriodicityHypothesisTests.cc | 35 ++++++++++++++++--------
 1 file changed, 24 insertions(+), 11 deletions(-)

diff --git a/lib/maths/CPeriodicityHypothesisTests.cc b/lib/maths/CPeriodicityHypothesisTests.cc
index 543f875be0..94b713f265 100644
--- a/lib/maths/CPeriodicityHypothesisTests.cc
+++ b/lib/maths/CPeriodicityHypothesisTests.cc
@@ -1046,22 +1046,27 @@ CPeriodicityHypothesisTests::best(const TNestedHypothesesVec &hypotheses) const
     TMinAccumulator vCutoff;
     for (const auto &summary : summaries)
     {
-        vCutoff.add(varianceAtPercentile(summary.s_V, summary.s_DF,
-                                         50.0 + CONFIDENCE_INTERVAL / 2.0));
+        if (summary.s_DF > 0.0)
+        {
+            vCutoff.add(varianceAtPercentile(summary.s_V, summary.s_DF,
+                                             50.0 + CONFIDENCE_INTERVAL / 2.0));
+        }
     }
-    LOG_TRACE("variance cutoff = " << vCutoff[0]);
-
-    TMinAccumulator df;
-    for (const auto &summary : summaries)
+    if (vCutoff.count() > 0)
     {
-        double v{varianceAtPercentile(summary.s_V, summary.s_DF,
-                                      50.0 - CONFIDENCE_INTERVAL / 2.0)};
-        if (v <= vCutoff[0] && df.add(-summary.s_DF))
+        LOG_TRACE("variance cutoff = " << vCutoff[0]);
+
+        TMinAccumulator df;
+        for (const auto &summary : summaries)
         {
-            result = summary.s_H;
+            double v{varianceAtPercentile(summary.s_V, summary.s_DF,
+                                          50.0 - CONFIDENCE_INTERVAL / 2.0)};
+            if (v <= vCutoff[0] && df.add(-summary.s_DF))
+            {
+                result = summary.s_H;
+            }
         }
     }
-
     return result;
 }
 
@@ -1456,6 +1461,10 @@ bool CPeriodicityHypothesisTests::testPeriod(const TTimeTimePr2Vec &windows,
     double B{stats.s_B};
     double scale{1.0 / M};
     double df0{B - stats.s_DF0};
+    if (df0 <= 0.0)
+    {
+        return false;
+    }
     double v0{varianceAtPercentile(stats.s_V0, df0, 50.0 + CONFIDENCE_INTERVAL / 2.0)};
     double vt{stats.s_Vt * v0};
     double at{stats.s_At * std::sqrt(v0 / scale)};
@@ -1574,6 +1583,10 @@ bool CPeriodicityHypothesisTests::testPartition(const TTimeTimePr2Vec &partition
     double B{stats.s_B};
     double scale{1.0 / stats.s_M};
     double df0{B - stats.s_DF0};
+    if (df0 <= 0.0)
+    {
+        return false;
+    }
     double v0{varianceAtPercentile(stats.s_V0, df0, 50.0 + CONFIDENCE_INTERVAL / 2.0)};
     double vt{stats.s_Vt * v0};
     LOG_TRACE("period = " << period);