Revert "[ML] Add min_version to model snapshot (#17)"

This reverts commit 155d2f8.

Author: dimitris-athanasiou

include/api/CModelSnapshotJsonWriter.h

@@ -32,7 +32,6 @@ class API_EXPORT CModelSnapshotJsonWriter
         //! Structure to store the model snapshot metadata
         struct SModelSnapshotReport
         {
-            std::string                       s_MinVersion;
             core_t::TTime                     s_SnapshotTimestamp;
             std::string                       s_Description;
             std::string                       s_SnapshotId;

lib/api/CAnomalyJob.cc

@@ -77,10 +77,6 @@ const std::string HIERARCHICAL_RESULTS_TAG("f");
 const std::string LATEST_RECORD_TIME_TAG("h");
 const std::string MODEL_PLOT_TAG("i");
 const std::string LAST_RESULTS_TIME_TAG("j");
-
-//! The minimum version required to read the state corresponding to a model snapshot.
-//! This should be updated every time there is a breaking change to the model state.
-const std::string MODEL_SNAPSHOT_MIN_VERSION("6.3.0");
 }
 
 // Statics
@@ -1375,7 +1371,6 @@ bool CAnomalyJob::persistState(const std::string &descriptionPrefix,
             if (m_PersistCompleteFunc)
             {
                 CModelSnapshotJsonWriter::SModelSnapshotReport modelSnapshotReport{
-                        MODEL_SNAPSHOT_MIN_VERSION,
                         snapshotTimestamp,
                         descriptionPrefix + core::CTimeUtils::toIso8601(snapshotTimestamp),
                         snapShotId,

lib/api/CModelSnapshotJsonWriter.cc

@@ -17,7 +17,6 @@ namespace
 
 // JSON field names
 const std::string JOB_ID("job_id");
-const std::string MIN_VERSION("min_version");
 const std::string TIMESTAMP("timestamp");
 const std::string MODEL_SNAPSHOT("model_snapshot");
 const std::string SNAPSHOT_ID("snapshot_id");
@@ -46,8 +45,6 @@ void CModelSnapshotJsonWriter::write(const SModelSnapshotReport &report)
 
     m_Writer.String(JOB_ID);
     m_Writer.String(m_JobId);
-    m_Writer.String(MIN_VERSION);
-    m_Writer.String(report.s_MinVersion);
     m_Writer.String(SNAPSHOT_ID);
     m_Writer.String(report.s_SnapshotId);
 

lib/api/unittest/CModelSnapshotJsonWriterTest.cc

@@ -24,7 +24,6 @@
 #include "CLineifiedJsonOutputWriterTest.h"
 #include "CLineifiedXmlInputParserTest.h"
 #include "CModelPlotDataJsonWriterTest.h"
-#include "CModelSnapshotJsonWriterTest.h"
 #include "CMultiFileDataAdderTest.h"
 #include "COutputChainerTest.h"
 #include "CRestorePreviousStateTest.h"
@@ -59,7 +58,6 @@ int main(int argc, const char **argv)
     runner.addTest( CLineifiedJsonOutputWriterTest::suite() );
     runner.addTest( CLineifiedXmlInputParserTest::suite() );
     runner.addTest( CModelPlotDataJsonWriterTest::suite() );
-    runner.addTest( CModelSnapshotJsonWriterTest::suite() );
     runner.addTest( CMultiFileDataAdderTest::suite() );
     runner.addTest( COutputChainerTest::suite() );
     runner.addTest( CRestorePreviousStateTest::suite() );

lib/api/unittest/CModelSnapshotJsonWriterTest.h

@@ -42,7 +42,6 @@ SRCS=\
 	CMockDataProcessor.cc \
 	CMockSearcher.cc \
 	CModelPlotDataJsonWriterTest.cc \
-	CModelSnapshotJsonWriterTest.cc \
 	CMultiFileDataAdderTest.cc \
 	COutputChainerTest.cc \
 	CRestorePreviousStateTest.cc \