Test example.com, googleapis.com, and content-autofill.googleapis.com #82898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justincr-elastic
added
>non-issue
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
danhermann
approved these changes
Jan 24, 2022
Contributor
danhermann
left a comment
danhermann
left a comment
There was a problem hiding this comment.
I added one comment below about re-ordering one of the tests and adding a comment about their intent. If you can do that, this PR looks good to me.
...est-common/src/test/java/org/elasticsearch/ingest/common/RegisteredDomainProcessorTests.java
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
I don't understand why the build randomly failed twice in unrelated areas. Retrying branch update again. |
Contributor
Author
|
@elasticmachine update branch |
Contributor
|
LGTM 👍 |
Contributor
Author
|
@elasticmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extra tests to RegisteredDomainProcessorTests.java.
See #67611 when tests were originally added.