From 2cd1a30a9dc30fef5b618a7f92be0273348011c7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Francisco=20Fern=C3=A1ndez=20Casta=C3=B1o?= Date: Thu, 28 Oct 2021 10:55:17 +0200 Subject: [PATCH] Fix RecoverySourceHandlerTests (#79546) Today RecoverySourceHandlerTests#generateFiles can generate files with different name but same content since the lengths that we use for tests are small. In order to avoid tripping assertions when we check that two files are different we should check that the name is different as well as the content are different. Closes #79502 --- .../indices/recovery/RecoverySourceHandlerTests.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/src/test/java/org/elasticsearch/indices/recovery/RecoverySourceHandlerTests.java b/server/src/test/java/org/elasticsearch/indices/recovery/RecoverySourceHandlerTests.java index db3de42f430dc..6c795cd5e93ef 100644 --- a/server/src/test/java/org/elasticsearch/indices/recovery/RecoverySourceHandlerTests.java +++ b/server/src/test/java/org/elasticsearch/indices/recovery/RecoverySourceHandlerTests.java @@ -1653,7 +1653,7 @@ private boolean containsSnapshotFile( } private boolean containsFile(List filesMetadata, StoreFileMetadata storeFileMetadata) { - return filesMetadata.stream().anyMatch(f -> f.isSame(storeFileMetadata)); + return filesMetadata.stream().anyMatch(f -> f.name().equals(storeFileMetadata.name()) && f.isSame(storeFileMetadata)); } private boolean containsFile(List files, String fileName, long length) {