From f448627f8da782fa016c6a29a0fe8ed11aabc3f4 Mon Sep 17 00:00:00 2001 From: James Rodewig <40268737+jrodewig@users.noreply.github.com> Date: Thu, 16 Sep 2021 22:16:52 -0400 Subject: [PATCH 1/4] [DOCS] Add breaking change for ECS user agent In 8.x, we'll ignore the `ecs` option for the `user_agent` ingest processor. This adds a related breaking change to the 8.0 migration docs. Relates to #38828 --- docs/reference/migration/migrate_8_0.asciidoc | 2 ++ .../migration/migrate_8_0/ingest.asciidoc | 21 +++++++++++++++++++ 2 files changed, 23 insertions(+) create mode 100644 docs/reference/migration/migrate_8_0/ingest.asciidoc diff --git a/docs/reference/migration/migrate_8_0.asciidoc b/docs/reference/migration/migrate_8_0.asciidoc index 38f8c02cadf11..db5e6bbeecea8 100644 --- a/docs/reference/migration/migrate_8_0.asciidoc +++ b/docs/reference/migration/migrate_8_0.asciidoc @@ -22,6 +22,7 @@ coming[8.0.0] * <> * <> * <> +* <> * <> * <> * <> @@ -98,6 +99,7 @@ include::migrate_8_0/eql.asciidoc[] include::migrate_8_0/http.asciidoc[] include::migrate_8_0/ilm.asciidoc[] include::migrate_8_0/indices.asciidoc[] +include::migrate_8_0/ingest.asciidoc[] include::migrate_8_0/java.asciidoc[] include::migrate_8_0/mappings.asciidoc[] include::migrate_8_0/network.asciidoc[] diff --git a/docs/reference/migration/migrate_8_0/ingest.asciidoc b/docs/reference/migration/migrate_8_0/ingest.asciidoc new file mode 100644 index 0000000000000..0906cbfe2457a --- /dev/null +++ b/docs/reference/migration/migrate_8_0/ingest.asciidoc @@ -0,0 +1,21 @@ +[discrete] +[[breaking_80_ingest_changes]] +==== Ingest pipeline changes + +//NOTE: The notable-breaking-changes tagged regions are re-used in the +//Installation and Upgrade Guide + +//tag::notable-breaking-changes[] +.The `user_agent` ingest processor's `ecs` parameter has no effect. +[%collapsible] +==== +*Details* + +In 7.2, we deprecated the `ecs` parameter for the `user_agent` ingest processor. +In 8.x, the `user_agent` ingest processor will only return {ecs-ref}[Elastic +Common Schema (ECS)] fields. + +*Impact* + +To avoid deprecation warnings, remove the parameter from your ingest pipelines. +If a pipeline specifies a `ecs` value, the value is ignored. +==== +//end::notable-breaking-changes[] From f877aa1c186a98ebfc721b3c5753ee93e70f1707 Mon Sep 17 00:00:00 2001 From: James Rodewig <40268737+jrodewig@users.noreply.github.com> Date: Fri, 17 Sep 2021 11:21:51 -0400 Subject: [PATCH 2/4] Fix typo --- docs/reference/migration/migrate_8_0/ingest.asciidoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/reference/migration/migrate_8_0/ingest.asciidoc b/docs/reference/migration/migrate_8_0/ingest.asciidoc index 0906cbfe2457a..93026fa8a20b4 100644 --- a/docs/reference/migration/migrate_8_0/ingest.asciidoc +++ b/docs/reference/migration/migrate_8_0/ingest.asciidoc @@ -16,6 +16,6 @@ Common Schema (ECS)] fields. *Impact* + To avoid deprecation warnings, remove the parameter from your ingest pipelines. -If a pipeline specifies a `ecs` value, the value is ignored. +If a pipeline specifies an `ecs` value, the value is ignored. ==== //end::notable-breaking-changes[] From 7166cfac0776d418b9c2dae32c03b4dd20bb7b71 Mon Sep 17 00:00:00 2001 From: James Rodewig <40268737+jrodewig@users.noreply.github.com> Date: Fri, 17 Sep 2021 16:39:14 -0400 Subject: [PATCH 3/4] tweak --- docs/reference/migration/migrate_8_0/ingest.asciidoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/reference/migration/migrate_8_0/ingest.asciidoc b/docs/reference/migration/migrate_8_0/ingest.asciidoc index 93026fa8a20b4..25d935fc27da7 100644 --- a/docs/reference/migration/migrate_8_0/ingest.asciidoc +++ b/docs/reference/migration/migrate_8_0/ingest.asciidoc @@ -12,7 +12,7 @@ *Details* + In 7.2, we deprecated the `ecs` parameter for the `user_agent` ingest processor. In 8.x, the `user_agent` ingest processor will only return {ecs-ref}[Elastic -Common Schema (ECS)] fields. +Common Schema (ECS)] fields, even if `ecs` is `false`. *Impact* + To avoid deprecation warnings, remove the parameter from your ingest pipelines. From 0bcc7805b9c7ddeae8afea570211b1a0a95574be Mon Sep 17 00:00:00 2001 From: James Rodewig <40268737+jrodewig@users.noreply.github.com> Date: Sun, 19 Sep 2021 16:51:43 -0400 Subject: [PATCH 4/4] Reword --- docs/reference/migration/migrate_8_0/ingest.asciidoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/reference/migration/migrate_8_0/ingest.asciidoc b/docs/reference/migration/migrate_8_0/ingest.asciidoc index 25d935fc27da7..d827a15de92ed 100644 --- a/docs/reference/migration/migrate_8_0/ingest.asciidoc +++ b/docs/reference/migration/migrate_8_0/ingest.asciidoc @@ -12,7 +12,7 @@ *Details* + In 7.2, we deprecated the `ecs` parameter for the `user_agent` ingest processor. In 8.x, the `user_agent` ingest processor will only return {ecs-ref}[Elastic -Common Schema (ECS)] fields, even if `ecs` is `false`. +Common Schema (ECS)] fields, regardless of the `ecs` value. *Impact* + To avoid deprecation warnings, remove the parameter from your ingest pipelines.