Wait for active shards when closing indices #66415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 7.x the default for `wait_for_active_shards` on a close index request is `NONE`, so in cases where we want to wait for active shards we must be explicit. Closes elastic#66411
DaveCTurner
added
>test
elasticmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
added a commit
that referenced
this pull request
Dec 15, 2020
Contributor
Author
|
NB this only affects 7.x, no change is needed on master. I removed the AwaitsFix from master in ed4ab8c. |
This was referenced Dec 15, 2020
DaveCTurner
requested review from
original-brownbear
and removed request for
tlrx
original-brownbear
approved these changes
Dec 16, 2020
Contributor
original-brownbear
left a comment
original-brownbear
left a comment
There was a problem hiding this comment.
LGTM we keep running into these in snapshot tests (I guess we could extract these close spots into a method in the abstract snapshot ITs so we have it in one place at some point :))
Contributor
Author
|
Thanks Armin. I'm tempted just to change the default to |
DaveCTurner
deleted the
2020-12-15-wait-for-active-shards-on-closing-indices
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 7.x the default for
wait_for_active_shardson a close index requestis
NONE, so in cases where we want to wait for active shards we mustbe explicit.
Closes #66411