Fix remove alias with must_exist #65141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove alias now parses the must_exist flag and results in a 404 (not found), if the index does not have the alias. Closes elastic#62642 Relates elastic#58100 Co-Authored-By: Luca Cavanna <[email protected]>
henningandersen
added
>bug
:Data Management/Indices APIs
elasticmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
javanna
approved these changes
Nov 17, 2020
Member
javanna
left a comment
javanna
left a comment
There was a problem hiding this comment.
LGTM thanks @henningandersen !!
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
Failure looks similar to #65048 @elasticmachine run elasticsearch-ci/2 |
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Nov 18, 2020
Remove alias now parses the must_exist flag and results in a 404 (not found), if the index does not have the alias. Closes elastic#62642 Relates elastic#58100 Co-Authored-By: Luca Cavanna <[email protected]>
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Nov 18, 2020
henningandersen
added a commit
that referenced
this pull request
Nov 18, 2020
Remove alias now parses the must_exist flag and results in a 404 (not found), if the index does not have the alias. Closes #62642 Relates #58100 Co-Authored-By: Luca Cavanna <[email protected]>
henningandersen
added a commit
that referenced
this pull request
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove alias now parses the must_exist flag and results in a 404
(not found), if the index does not have the alias.
Closes #62642
Relates #58100
Co-Authored-By: Luca Cavanna [email protected]