Render script params in script field xcontent #59813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the rendering of the `script` field in the `script` field type. Originally we weren't rendering the `params` and such because we couldn't parse them. But we can parse them now so we should render them. This updates the integration tests to include params and adds an integration test that fetches the mapping.
nik9000
added
the
:Search/Search
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
30 tasks
javanna
approved these changes
Jul 20, 2020
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the rendering of the
scriptfield in thescriptfieldtype. Originally we weren't rendering the
paramsand such because wecouldn't parse them. But we can parse them now so we should render them.
This updates the integration tests to include params and adds an
integration test that fetches the mapping.
Relates to #59332