diff --git a/server/src/main/java/org/elasticsearch/index/mapper/AbstractGeometryFieldMapper.java b/server/src/main/java/org/elasticsearch/index/mapper/AbstractGeometryFieldMapper.java index 0dbfc5070706d..06aeff823e099 100644 --- a/server/src/main/java/org/elasticsearch/index/mapper/AbstractGeometryFieldMapper.java +++ b/server/src/main/java/org/elasticsearch/index/mapper/AbstractGeometryFieldMapper.java @@ -266,8 +266,9 @@ protected void mergeOptions(FieldMapper other, List conflicts) { } @Override - public AbstractGeometryFieldType fieldType() { - return (AbstractGeometryFieldType)mappedFieldType; + @SuppressWarnings("unchecked") + public AbstractGeometryFieldType fieldType() { + return (AbstractGeometryFieldType) mappedFieldType; } @Override @@ -282,10 +283,10 @@ protected void parseCreateField(ParseContext context) throws IOException { /** parsing logic for geometry indexing */ @Override public void parse(ParseContext context) throws IOException { - AbstractGeometryFieldMapper.AbstractGeometryFieldType mappedFieldType = fieldType(); + AbstractGeometryFieldType mappedFieldType = fieldType(); - @SuppressWarnings("unchecked") Indexer geometryIndexer = mappedFieldType.geometryIndexer(); - @SuppressWarnings("unchecked") Parser geometryParser = mappedFieldType.geometryParser(); + Indexer geometryIndexer = mappedFieldType.geometryIndexer(); + Parser geometryParser = mappedFieldType.geometryParser(); try { Processed shape = context.parseExternalValue(geometryIndexer.processedClass()); if (shape == null) { diff --git a/server/src/main/java/org/elasticsearch/index/mapper/GeoPointFieldMapper.java b/server/src/main/java/org/elasticsearch/index/mapper/GeoPointFieldMapper.java index 482996d307e64..aec585ad615a9 100644 --- a/server/src/main/java/org/elasticsearch/index/mapper/GeoPointFieldMapper.java +++ b/server/src/main/java/org/elasticsearch/index/mapper/GeoPointFieldMapper.java @@ -32,6 +32,7 @@ import org.elasticsearch.index.fielddata.IndexFieldData; import org.elasticsearch.index.fielddata.plain.AbstractLatLonPointIndexFieldData; import org.elasticsearch.index.query.VectorGeoPointShapeQueryProcessor; +import org.elasticsearch.index.mapper.GeoPointFieldMapper.ParsedGeoPoint; import org.elasticsearch.search.aggregations.support.CoreValuesSourceType; import java.io.IOException; @@ -45,7 +46,7 @@ * * Uses lucene 6 LatLonPoint encoding */ -public class GeoPointFieldMapper extends AbstractPointGeometryFieldMapper, List> { +public class GeoPointFieldMapper extends AbstractPointGeometryFieldMapper, List> { public static final String CONTENT_TYPE = "geo_point"; public static final FieldType FIELD_TYPE = new FieldType(); static { @@ -163,7 +164,7 @@ protected ParsedPoint newParsedPoint() { return new ParsedGeoPoint(); } - public static class GeoPointFieldType extends AbstractPointGeometryFieldType, List> { + public static class GeoPointFieldType extends AbstractPointGeometryFieldType, List> { public GeoPointFieldType(String name, boolean indexed, boolean hasDocValues, Map meta) { super(name, indexed, hasDocValues, meta); } @@ -242,7 +243,7 @@ public int hashCode() { } } - protected static class GeoPointIndexer implements Indexer, List> { + protected static class GeoPointIndexer implements Indexer, List> { protected final GeoPointFieldType fieldType; @@ -251,7 +252,7 @@ protected static class GeoPointIndexer implements Indexer, } @Override - public List prepareForIndexing(List geoPoints) { + public List prepareForIndexing(List geoPoints) { if (geoPoints == null || geoPoints.isEmpty()) { return Collections.emptyList(); } @@ -259,12 +260,12 @@ public List prepareForIndexing(List geoPoints) { } @Override - public Class> processedClass() { - return (Class>)(Object)List.class; + public Class> processedClass() { + return (Class>)(Object)List.class; } @Override - public List indexShape(ParseContext context, List points) { + public List indexShape(ParseContext context, List points) { ArrayList fields = new ArrayList<>(points.size()); for (GeoPoint point : points) { fields.add(new LatLonPoint(fieldType.name(), point.lat(), point.lon())); diff --git a/x-pack/plugin/spatial/src/main/java/org/elasticsearch/xpack/spatial/index/mapper/PointFieldMapper.java b/x-pack/plugin/spatial/src/main/java/org/elasticsearch/xpack/spatial/index/mapper/PointFieldMapper.java index 3278911094f90..c34fc29ca1af4 100644 --- a/x-pack/plugin/spatial/src/main/java/org/elasticsearch/xpack/spatial/index/mapper/PointFieldMapper.java +++ b/x-pack/plugin/spatial/src/main/java/org/elasticsearch/xpack/spatial/index/mapper/PointFieldMapper.java @@ -17,6 +17,7 @@ import org.elasticsearch.index.mapper.ParseContext; import org.elasticsearch.xpack.spatial.common.CartesianPoint; import org.elasticsearch.xpack.spatial.index.query.ShapeQueryPointProcessor; +import org.elasticsearch.xpack.spatial.index.mapper.PointFieldMapper.ParsedCartesianPoint; import java.io.IOException; import java.util.ArrayList; @@ -29,7 +30,7 @@ * * Uses lucene 8 XYPoint encoding */ -public class PointFieldMapper extends AbstractPointGeometryFieldMapper, List> { +public class PointFieldMapper extends AbstractPointGeometryFieldMapper, List> { public static final String CONTENT_TYPE = "point"; public static class Builder extends AbstractPointGeometryFieldMapper.Builder { @@ -95,7 +96,6 @@ public PointFieldMapper(String simpleName, FieldType fieldType, MappedFieldType } @Override - @SuppressWarnings("unchecked") protected void addStoredFields(ParseContext context, List points) { for (CartesianPoint point : points) { context.doc().add(new StoredField(fieldType().name(), point.toString())); @@ -103,7 +103,6 @@ protected void addStoredFields(ParseContext context, List points, List fields, ParseContext context) { for (CartesianPoint point : points) { @@ -123,10 +122,10 @@ protected String contentType() { @Override public PointFieldType fieldType() { - return (PointFieldType)mappedFieldType; + return (PointFieldType) mappedFieldType; } - public static class PointFieldType extends AbstractPointGeometryFieldType, List> { + public static class PointFieldType extends AbstractPointGeometryFieldType, List> { public PointFieldType(String name, boolean indexed, boolean hasDocValues, Map meta) { super(name, indexed, hasDocValues, meta); } @@ -190,7 +189,7 @@ public int hashCode() { } } - protected static class PointIndexer implements Indexer, List> { + protected static class PointIndexer implements Indexer, List> { protected final PointFieldType fieldType; PointIndexer(PointFieldType fieldType) { @@ -198,7 +197,7 @@ protected static class PointIndexer implements Indexer prepareForIndexing(List points) { + public List prepareForIndexing(List points) { if (points == null || points.isEmpty()) { return Collections.emptyList(); } @@ -207,14 +206,14 @@ public List prepareForIndexing(List @Override @SuppressWarnings("unchecked") - public Class> processedClass() { - return (Class>)(Object)List.class; + public Class> processedClass() { + return (Class>)(Object)List.class; } @Override - public List indexShape(ParseContext context, List points) { + public List indexShape(ParseContext context, List points) { ArrayList fields = new ArrayList<>(1); - for (ParsedCartesianPoint point : points) { + for (CartesianPoint point : points) { fields.add(new XYPointField(fieldType.name(), point.getX(), point.getY())); } return fields; diff --git a/x-pack/plugin/spatial/src/main/java/org/elasticsearch/xpack/spatial/index/mapper/ShapeFieldMapper.java b/x-pack/plugin/spatial/src/main/java/org/elasticsearch/xpack/spatial/index/mapper/ShapeFieldMapper.java index 2bd0e239986f2..09cdd1ed63fe4 100644 --- a/x-pack/plugin/spatial/src/main/java/org/elasticsearch/xpack/spatial/index/mapper/ShapeFieldMapper.java +++ b/x-pack/plugin/spatial/src/main/java/org/elasticsearch/xpack/spatial/index/mapper/ShapeFieldMapper.java @@ -75,8 +75,7 @@ public Builder newBuilder(String name, Map params) { } } - @SuppressWarnings({"unchecked", "rawtypes"}) - public static final class ShapeFieldType extends AbstractShapeGeometryFieldType { + public static final class ShapeFieldType extends AbstractShapeGeometryFieldType { public ShapeFieldType(String name, boolean indexed, boolean hasDocValues, Map meta) { super(name, indexed, hasDocValues, meta); }