Scripting: Move script_cache into _nodes/stats #59265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed settings: * `script.cache.max_size` * `script.cache.expire` * `script.max_compilations_rate` Refs: elastic#50152
Updated `_nodes/stats`:
* Remove `script_cache`
* Update `script` in `_node/stats` to include stats per context:
```
"script": {
"compilations": 1,
"cache_evictions": 0,
"compilation_limit_triggered": 0,
"contexts":[
{
"context": "aggregation_selector",
"compilations": 0,
"cache_evictions": 0,
"compilation_limit_triggered": 0
},
```
Refs: elastic#50152
…152-painless-limit-per-context__07__node-stats
…152-painless-limit-per-context__07__node-stats
stu-elastic
added
:Core/Infra/Scripting
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Scripting) |
stu-elastic
commented
Jul 9, 2020
server/src/test/java/org/elasticsearch/action/admin/cluster/node/stats/NodeStatsTests.java
Outdated
Show resolved
Hide resolved
jdconrad
approved these changes
Jul 9, 2020
stu-elastic
commented
Jul 9, 2020
server/src/test/java/org/elasticsearch/action/admin/cluster/node/stats/NodeStatsTests.java
Outdated
Show resolved
Hide resolved
…152-painless-limit-per-context__07__node-stats
stu-elastic
added a commit
to stu-elastic/elasticsearch
that referenced
this pull request
Jul 9, 2020
stu-elastic
added a commit
that referenced
this pull request
Jul 9, 2020
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending: #59262
Updated
_nodes/stats:script_cachescriptin_node/statsto include stats per context:Refs: #50152