Per processor description for verbose simulate #58207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For ingest node processors a per processor description was recently added. This commit displays that description in the verbose output of the pipeline simulation. related elastic#57906
jakelandis
added
>enhancement
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Ingest) |
elasticmachine
added
the
Team:Data Management
talevy
reviewed
Jun 17, 2020
Contributor
talevy
left a comment
talevy
left a comment
There was a problem hiding this comment.
Overall looks good!
Do we need at least a unit test for the version-guard serialization?
Contributor
Author
added a test here: https://github.com/elastic/elasticsearch/pull/58207/commits/3862f4c3926a851bcd0fea8747125fc3d96efc4f |
talevy
approved these changes
Jul 21, 2020
Contributor
Author
|
thanks @talevy ! |
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Jul 21, 2020
For ingest node processors a per processor description was recently added. This commit displays that description in the verbose output of the pipeline simulation. related elastic#57906
jakelandis
added a commit
that referenced
this pull request
Jul 21, 2020
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ingest node processors a per processor description
was recently added. This commit displays that description
in the verbose output of the pipeline simulation.
related #57906
======
@talevy - On #57906 it was briefly discussed this not was necessary. Which I agree, not necessary...but it is a pretty trivial change and feels more complete to include it the verbose output (especially since the tag is already displayed).
cc @jloleysens