Adjust version mute for reload secure settings #56938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can safely run this test after 7.7.0
jkakavas
added
>test
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/REST API) |
jkakavas
commented
May 19, 2020
| version: " - 7.9.99" | ||
| reason: "support for reloading password protected keystores was introduced in 8.0.0" | ||
| version: " - 7.6.99" | ||
| reason: "support for reloading password protected keystores was introduced in 7.7.0" |
mark-vieira
approved these changes
May 19, 2020
Contributor
mark-vieira
left a comment
mark-vieira
left a comment
There was a problem hiding this comment.
LGTM, however I see this PR is missing labels for 7.7 and 7.x branches. I assume i should be backported there as well?
Contributor
Author
We don't have a |
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
May 19, 2020
We can safely run the reload_secure_settings tests after 7.7.0 , the relevant changes have long been backported there
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
May 19, 2020
We can safely run the reload_secure_settings tests after 7.7.0 , the relevant changes have long been backported there
jkakavas
added a commit
that referenced
this pull request
May 19, 2020
jkakavas
added a commit
that referenced
this pull request
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can safely run the reload_secure_settings tests
after 7.7.0 , the relevant changes have long been
backported there