Add geo_shape mapper supporting doc-values in Spatial Plugin #55037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talevy
added
WIP
:Analytics/Geo
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
talevy
force-pushed
the
x-pack-geo-shape
branch
6 times, most recently
from
1238374 to
b79b2f8
Compare
After elastic#53562, the `geo_shape` field mapper is registered within a module. This opens the door for introducing a new `geo_shape` field mapper into the Spatial Plugin that has doc-values support. This is very much an extension of server's GeoShapeFieldMapper, but with the addition of the doc values implementation.
talevy
force-pushed
the
x-pack-geo-shape
branch
from
b79b2f8 to
bce21fb
Compare
talevy
commented
Apr 13, 2020
| || dataType == SCALED_FLOAT // because of scaling_factor | ||
| || dataType == CONSTANT_KEYWORD | ||
| || dataType == GEO_POINT | ||
| || dataType == GEO_SHAPE |
Contributor
Author
There was a problem hiding this comment.
@elastic/es-ql does anyone know why the geo_shape field was here as isFromDocValuesOnly when the field did not have doc values?
Contributor
Author
|
run elasticsearch-ci/packaging-sample-unix-docker |
Contributor
Author
|
run elasticsearch-ci/2 |
iverase
reviewed
Apr 15, 2020
...main/java/org/elasticsearch/xpack/spatial/index/mapper/GeoShapeWithDocValuesFieldMapper.java
Outdated
Show resolved
Hide resolved
iverase
approved these changes
Apr 16, 2020
Contributor
iverase
left a comment
iverase
left a comment
There was a problem hiding this comment.
LGTM. I think we need to reorder the class under mapper package but we can do that in a follow up PR.
Collaborator
|
Pinging @elastic/es-ui (:ES-UI) |
talevy
added a commit
that referenced
this pull request
Apr 22, 2020
…#55500) After #53562, the `geo_shape` field mapper is registered within a module. This opens the door for introducing a new `geo_shape` field mapper into the Spatial Plugin that has doc-values support. This is very much an extension of server's GeoShapeFieldMapper, but with the addition of the doc values implementation.
talevy
added a commit
to talevy/elasticsearch
that referenced
this pull request
Apr 22, 2020
After backporting the geo_shape with doc-values field to 7.x(7.8), this the version boundary for this feature can now be pulled from 8.0 to 7.8. relates elastic#55037.
talevy
added a commit
that referenced
this pull request
Apr 22, 2020
After backporting the geo_shape with doc-values field to 7.x(7.8), this the version boundary for this feature can now be pulled from 8.0 to 7.8. relates #55037.
17 tasks
cjcenizal
added
the
Team:Deployment Management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #53562, the
geo_shapefield mapper is registered withina module. This opens the door for introducing a new
geo_shapefield mapper into the Spatial Plugin that has doc-values support.
This is very much an extension of server's GeoShapeFieldMapper,
but with the addition of the doc values implementation.
this adds a
doc_valuesparam to thegeo_shapemapping that defaults to true