Remove guard around atomic move supported check #54917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use to allow non-data/non-master nodes to not have a persistent data path via the undocumented node.local_storage setting. We recently removed this setting, but left behind was a guard around a check that the data paths support atomic moves. This commit unguards this check, so that all nodes are required to have persistent storage that supports atomic move operations.
jasontedor
added
>breaking
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
rjernst
approved these changes
Apr 7, 2020
Member
Author
|
It’s related but somewhat distinct from the previous change since this detection did not use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use to allow non-data/non-master nodes to not have a persistent data path via the undocumented node.local_storage setting. We recently removed this setting, but left behind was a guard around a check that the data paths support atomic moves. This commit unguards this check, so that all nodes are required to have persistent storage that supports atomic move operations.
Relates #54381