Skip to content

[DOCS] Clarify docs: how to add Routing enforcement #53945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2020
Merged

[DOCS] Clarify docs: how to add Routing enforcement #53945

merged 1 commit into from
Mar 23, 2020

Conversation

@cjcjameson
Copy link
Contributor

@cjcjameson cjcjameson commented Mar 23, 2020

In 6.8, the _doc made sense: https://www.elastic.co/guide/en/elasticsearch/reference/6.8/mapping-routing-field.html

but now it doesn't, and is confusing. I assume it applies to all documents(??)

@cla-checker-service
Copy link

cla-checker-service bot commented Mar 23, 2020 •
edited
Loading

💚 CLA has been signed

@cjcjameson
Copy link
Contributor Author

cjcjameson commented Mar 23, 2020

I did sign before submitting; feel free to refresh the CLA verification.

@jrodewig jrodewig self-requested a review March 23, 2020 14:53
@jrodewig jrodewig added :Search Foundations/Mapping Index mappings, including merging and defining field types >docs General docs changes labels Mar 23, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 23, 2020

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 23, 2020

Pinging @elastic/es-search (:Search/Mapping)

@jrodewig
Copy link
Contributor

jrodewig commented Mar 23, 2020

HI @cjcjameson

Can you ensure that you have signed the CLA using the same @users.noreply.github.com email address associated with this commit?

That's likely causing the CLA check to fail. Thanks!

@jrodewig
Copy link
Contributor

jrodewig commented Mar 23, 2020

@elasticmachine test this please

jrodewig
jrodewig approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'll merge after the CLA CI test passes.

@cjcjameson
Clarify docs: how to add Routing enforcement
06ff494 
In 6.8, the `_doc` made sense: https://www.elastic.co/guide/en/elasticsearch/reference/6.8/mapping-routing-field.html

but now it doesn't, and is confusing. I assume it applies to all documents(??)
@cjcjameson cjcjameson changed the base branch from 7.6 to master March 23, 2020 15:57
@cjcjameson
Copy link
Contributor Author

cjcjameson commented Mar 23, 2020

@jrodewig thanks! I changed the author and also repointed this MR to the master branch. Can you do the backporting? What's the system for backporting docs changes to the right branches?

Also filed #53991 regarding the CLA

@jrodewig
Copy link
Contributor

jrodewig commented Mar 23, 2020

@cjcjameson Thanks. It looks like that solved the CLA issue.

I'm going to change the base branch back to 7.6. That'll let me merge it and backport the changes.
For this repo, the repo maintainers (me in the case) handle the redirects. I'll get this applied to doc branches we still maintain.

Thanks again!

@jrodewig jrodewig changed the base branch from master to 7.6 March 23, 2020 16:12
@jrodewig jrodewig changed the title Clarify docs: how to add Routing enforcement [DOCS] Clarify docs: how to add Routing enforcement Mar 23, 2020
@jrodewig jrodewig changed the base branch from 7.6 to master March 23, 2020 16:13
@jrodewig
Copy link
Contributor

jrodewig commented Mar 23, 2020

@elasticmachine test this please.

@jrodewig
Copy link
Contributor

jrodewig commented Mar 23, 2020

Switched base branch back to master. That seemed to clear up the merge conflicts. Will merge after CI is complete.

@jrodewig jrodewig merged commit 34feb3c into elastic:master Mar 23, 2020
jrodewig pushed a commit that referenced this pull request Mar 23, 2020
@cjcjameson @jrodewig
[DOCS] Clarify routing enforcement in docs (#53945)
5ac8b79 
Removes a mention of the `_doc` mapping type that's
no longer applicable now that mapping types are
removed/deprecated.
jrodewig pushed a commit that referenced this pull request Mar 23, 2020
@cjcjameson @jrodewig
[DOCS] Clarify routing enforcement in docs (#53945)
55f1b63 
Removes a mention of the `_doc` mapping type that's
no longer applicable now that mapping types are
removed/deprecated.
@cjcjameson cjcjameson mentioned this pull request Mar 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jrodewig jrodewig jrodewig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

>docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types v7.6.3 v7.7.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cjcjameson @elasticmachine @jrodewig @jakelandis