Make DeleteStep retryable #52494
Merged
Make DeleteStep retryable #52494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change marks `DeleteStep` as retryable and adds test to make sure we really can invoke it again.
probakowski
added
>enhancement
:Data Management/ILM+SLM
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
andreidan
reviewed
Feb 19, 2020
x-pack/plugin/ilm/src/test/java/org/elasticsearch/xpack/ilm/DeleteStepTests.java
Outdated
Show resolved
Hide resolved
andreidan
approved these changes
Feb 19, 2020
Contributor
andreidan
left a comment
andreidan
left a comment
There was a problem hiding this comment.
LGTM, thanks for working on this Przemko
probakowski
added a commit
to probakowski/elasticsearch
that referenced
this pull request
Feb 19, 2020
* Make DeleteStep retryable This change marks `DeleteStep` as retryable and adds test to make sure we really can invoke it again. * Fix unused import * revert unneeded changes * test reworked
probakowski
added a commit
that referenced
this pull request
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change marks
DeleteStepas retryable and adds test to make sure we really can invoke it again.