Make soft-deletes mandatory in 8.0 #51122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>breaking
>non-issue
:Distributed Indexing/Engine
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Engine) |
ywelsch
suggested changes
Jan 16, 2020
server/src/main/java/org/elasticsearch/cluster/metadata/MetaDataCreateIndexService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/MetaDataCreateIndexService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/admin/indices/shrink/TransportResizeAction.java
Outdated
Show resolved
Hide resolved
Member
Author
|
@ywelsch Thank you for catching these issues. I thought about always enabling soft-deletes for restored and resized indices whether their sources have soft-deletes or not. But I forgot to wire the setting properly (sorry). Anyway, I think it's safer to keep the setting disabled. I have addressed the resize in 0ecee87 and snapshot in 9a992a9. Can you take another look? |
Member
Author
|
Thanks Yannick. |
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Creating indices with soft deletes disabled is no longer supported in 8.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating indices with soft deletes disabled is no longer supported in 8.0.