Fix meta version of task index mapping #50363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
added
>bug
:Search Foundations/Mapping
Collaborator
|
Pinging @elastic/es-search (:Search/Mapping) |
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Task Management) |
Contributor
Author
|
Note that this is targeted to 7x as the fix for master is included in #50359 |
henningandersen
approved these changes
Dec 20, 2019
Contributor
henningandersen
left a comment
henningandersen
left a comment
There was a problem hiding this comment.
LGTM. Nice catch, thanks @romseygeek
romseygeek
added a commit
that referenced
this pull request
Dec 20, 2019
The built-in task index mapping has a version field in its metadata, so that the TaskResultsService can check to see if it needs to update mappings when a new task result is stored. #48393 updated this version in TaskResultsService but omitted to change the version in the mapping itself, so a mapping update is applied every time a new task result is stored. This commit updates the mapping version so that it corresponds to the version in TaskResultsService.
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The built-in task index mapping has a
versionfield in its metadata, so thatthe
TaskResultsServicecan check to see if it needs to update mappings whena new task result is stored. #48393 updated this version in
TaskResultsServicebut omitted to change the version in the mapping itself, so a mapping update
is applied every time a new task result is stored.
This commit updates the mapping version so that it corresponds to the version
in
TaskResultsService.