Add Validation for maxQueryTerms to be greater than 0 for MoreLikeThisQuery #49966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sQueryBuilder and MoreLikeThisQuery
Revert rpm.asciidoc changes
Revert rpm.asciidoc changes
cbuescher
added
:Search/Search
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
cbuescher
approved these changes
Dec 9, 2019
Member
cbuescher
left a comment
cbuescher
left a comment
There was a problem hiding this comment.
@vishnuchilamakuru thanks for picking this up. LGTM
I will run the CI test suite before merging.
Member
|
@elasticmachine test this please |
Member
|
@elasticmachine update branch |
Member
|
@elasticmachine test this please |
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
…sQuery (elastic#49966) Adds validation for maxQueryTerms to be greater than 0 for MoreLikeThisQuery and MoreLikeThisQueryBuilder. Closes elastic#49927
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request resolves the open issue #49927 .
Code Changes:
Add Validation for maxQueryTerms to be greater than 0 for
MoreLikeThisQueryandMoreLikeThisQueryBuilder.