Allow list of IPs in geoip ingest processor #49573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change lets you use array of IPs in addition to string in geoip processor source field. It will set array containing geoip data for each element in source, unless first_only parameter option is enabled, then only first found will be returned. Closes elastic#46193
probakowski
added
>bug
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Ingest) |
martijnvg
reviewed
Nov 26, 2019
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
Looks good! I left a few comments.
modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/GeoIpProcessor.java
Outdated
Show resolved
Hide resolved
modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/GeoIpProcessor.java
Outdated
Show resolved
Hide resolved
modules/ingest-geoip/src/test/java/org/elasticsearch/ingest/geoip/GeoIpProcessorTests.java
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine run elasticsearch-ci/2 |
jbaiera
approved these changes
Dec 3, 2019
modules/ingest-geoip/src/test/java/org/elasticsearch/ingest/geoip/GeoIpProcessorTests.java
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/oss-distro-docs |
probakowski
added a commit
to probakowski/elasticsearch
that referenced
this pull request
Dec 6, 2019
* Allow list of IPs in geoip ingest processor This change lets you use array of IPs in addition to string in geoip processor source field. It will set array containing geoip data for each element in source, unless first_only parameter option is enabled, then only first found will be returned. Closes elastic#46193
probakowski
added a commit
that referenced
this pull request
Dec 6, 2019
* Allow list of IPs in geoip ingest processor This change lets you use array of IPs in addition to string in geoip processor source field. It will set array containing geoip data for each element in source, unless first_only parameter option is enabled, then only first found will be returned. Closes #46193
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
* Allow list of IPs in geoip ingest processor This change lets you use array of IPs in addition to string in geoip processor source field. It will set array containing geoip data for each element in source, unless first_only parameter option is enabled, then only first found will be returned. Closes elastic#46193
This was referenced Feb 3, 2020
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 21, 2020
Mpdreamz
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 21, 2020
github-actions bot
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 21, 2020
Mpdreamz
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 21, 2020
Relates: #4341, elastic/elasticsearch#49573 Co-authored-by: Russ Cam <[email protected]>
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 23, 2020
Relates: #4341, elastic/elasticsearch#49573 (cherry picked from commit d66cb08)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change lets you use array of IPs in addition to string in geoip processor source field.
It will set array containing geoip data for each element in source, unless first_only parameter
option is enabled, then only first found will be returned.
Closes #46193