print id detail when id is too long. #49433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
added
the
:Distributed Indexing/CRUD
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/CRUD) |
dnhatn
reviewed
Nov 22, 2019
Member
dnhatn
left a comment
dnhatn
left a comment
There was a problem hiding this comment.
This change looks good. I left a minor suggestion. Can you also add a unit test for this change? Thank you.
Member
|
@elasticmachine ok to test |
Member
|
@elasticmachine update branch |
dnhatn
pushed a commit
that referenced
this pull request
Nov 24, 2019
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print id detail when
idis too long for easy debug.