mmap dim files in HybridDirectory #49272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
>enhancement
:Distributed Indexing/Store
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Store) |
jpountz
approved these changes
Nov 18, 2019
Contributor
jpountz
left a comment
jpountz
left a comment
There was a problem hiding this comment.
This sounds good to me and I'd backport to 7.x, but I'm curious what @danielmitterdorfer thinks.
danielmitterdorfer
approved these changes
Nov 19, 2019
Member
There was a problem hiding this comment.
LGTM. I agree with @jpountz to backport to 7.x as well.
Contributor
Author
|
@jpountz @danielmitterdorfer Thanks for the reviews. Will add to 7.x as well. |
jdconrad
added a commit
that referenced
this pull request
Nov 19, 2019
This change mmaps dim files in HybridDirectory to take advantage of off- heap BKD trees. This is based off of (#48509) via (https://issues.apache.org/jira/browse/LUCENE-8932).
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change mmaps dim files in HybridDirectory to take advantage of off-heap BKD trees. This is based off of (#48509) via (https://issues.apache.org/jira/browse/LUCENE-8932).
Should this be backported prior to 8.0?