Avoid precision loss in DocValueFormat.RAW#parseLong #49063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
Contributor
|
@not-napoleon you might have a better handle on this area than me, would you mind reviewing? ❤️ |
Member
|
@elasticmachine test this please |
not-napoleon
approved these changes
Nov 14, 2019
Member
not-napoleon
left a comment
not-napoleon
left a comment
There was a problem hiding this comment.
This looks fine to me, but I do wonder if there was some reason we weren't doing this in the first place. @jpountz I think you originally wrote this, do you know of some reason we wouldn't want to try parsing as a long first before falling back to rounding?
| expectThrows(IllegalArgumentException.class, () -> DocValueFormat.RAW.parseLong("", randomBoolean(), null)); | ||
| expectThrows(IllegalArgumentException.class, () -> DocValueFormat.RAW.parseLong("abc", randomBoolean(), null)); | ||
| expectThrows(IllegalArgumentException.class, () -> DocValueFormat.RAW.parseDouble("", randomBoolean(), null)); | ||
| expectThrows(IllegalArgumentException.class, () -> DocValueFormat.RAW.parseDouble("abc", randomBoolean(), null)); |
Contributor
|
@not-napoleon No good reason, this is a true bug. :) |
Member
|
@elasticmachine run elasticsearch-ci/1 |
not-napoleon
pushed a commit
to not-napoleon/elasticsearch
that referenced
this pull request
Nov 15, 2019
not-napoleon
added a commit
that referenced
this pull request
Nov 15, 2019
Contributor
Author
|
The 6.8 branch is still maintained, right? Could this fix be backported to that branch as well please? |
not-napoleon
added a commit
that referenced
this pull request
Nov 19, 2019
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #38692