Cleanup Redundant Futures in Recovery Code #48805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up to elastic#48110 cleaning up the redundant future uses that were left over from that change.
original-brownbear
added
>non-issue
:Distributed Indexing/Recovery
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Recovery) |
dnhatn
approved these changes
Nov 2, 2019
Member
dnhatn
left a comment
dnhatn
left a comment
There was a problem hiding this comment.
LGTM. Thanks @original-brownbear.
Contributor
Author
|
Thanks Nhat! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Nov 2, 2019
Follow up to elastic#48110 cleaning up the redundant future uses that were left over from that change.
original-brownbear
added a commit
that referenced
this pull request
Nov 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #48110 cleaning up the redundant future
uses that were left over from that change.