Package the JDK into jdk.app on macOS #48765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit packages the bundled JDK into jdk.app on macOS to assist with notarization there.
jasontedor
added
>enhancement
:Delivery/Packaging
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Packaging) |
Member
Author
|
@elasticmachine run elasticsearch-ci/bwc |
Member
Author
|
@elasticmachine update branch |
mark-vieira
approved these changes
Oct 31, 2019
Contributor
mark-vieira
left a comment
mark-vieira
left a comment
There was a problem hiding this comment.
LGTM.
@jasontedor could you provide some context as to how this helps with notarization? It's not immediately obvious to me what exactly renaming the directory we put the jdk in accomplishes to that effect.
Member
Author
|
@mark-vieira It puts the directory structure into the format that Apple expects for application bundles ( |
jasontedor
added a commit
that referenced
this pull request
Oct 31, 2019
This commit packages the bundled JDK into jdk.app on macOS to assist with notarization there.
jasontedor
added a commit
that referenced
this pull request
Oct 31, 2019
This commit packages the bundled JDK into jdk.app on macOS to assist with notarization there.
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit packages the bundled JDK into jdk.app on macOS to assist with notarization there.