diff --git a/buildSrc/src/main/groovy/org/elasticsearch/gradle/BuildPlugin.groovy b/buildSrc/src/main/groovy/org/elasticsearch/gradle/BuildPlugin.groovy index b64ac3060d779..32f8a5fa52c1c 100644 --- a/buildSrc/src/main/groovy/org/elasticsearch/gradle/BuildPlugin.groovy +++ b/buildSrc/src/main/groovy/org/elasticsearch/gradle/BuildPlugin.groovy @@ -827,6 +827,8 @@ class BuildPlugin implements Plugin { } else { nonInputProperties.systemProperty('runtime.java', "${-> (ext.get('runtimeJavaVersion') as JavaVersion).getMajorVersion()}") } + //TODO remove once jvm.options are added to test system properties + test.systemProperty ('java.locale.providers','SPI,COMPAT') } test.jvmArgumentProviders.add(nonInputProperties) @@ -861,8 +863,6 @@ class BuildPlugin implements Plugin { 'tests.security.manager': 'true', 'jna.nosys': 'true' - //TODO remove once jvm.options are added to test system properties - test.systemProperty ('java.locale.providers','SPI,COMPAT') // ignore changing test seed when build is passed -Dignore.tests.seed for cacheability experimentation if (System.getProperty('ignore.tests.seed') != null) { diff --git a/buildSrc/src/main/groovy/org/elasticsearch/gradle/test/RestIntegTestTask.groovy b/buildSrc/src/main/groovy/org/elasticsearch/gradle/test/RestIntegTestTask.groovy index 5808e22780b3e..f07ce2b08f438 100644 --- a/buildSrc/src/main/groovy/org/elasticsearch/gradle/test/RestIntegTestTask.groovy +++ b/buildSrc/src/main/groovy/org/elasticsearch/gradle/test/RestIntegTestTask.groovy @@ -24,7 +24,6 @@ import org.elasticsearch.gradle.testclusters.RestTestRunnerTask import org.elasticsearch.gradle.tool.Boilerplate import org.elasticsearch.gradle.tool.ClasspathUtils import org.gradle.api.DefaultTask -import org.gradle.api.JavaVersion import org.gradle.api.Task import org.gradle.api.file.FileCopyDetails import org.gradle.api.tasks.Copy diff --git a/server/src/main/java/org/elasticsearch/common/time/DateFormatters.java b/server/src/main/java/org/elasticsearch/common/time/DateFormatters.java index 293be893d293a..d09493849ce85 100644 --- a/server/src/main/java/org/elasticsearch/common/time/DateFormatters.java +++ b/server/src/main/java/org/elasticsearch/common/time/DateFormatters.java @@ -1931,7 +1931,7 @@ private static LocalDate getLocalDate(TemporalAccessor accessor) { } else { return LocalDate.of(year, accessor.get(MONTH_OF_YEAR), 1); } - } else + } return LOCALDATE_EPOCH; } @@ -1943,7 +1943,6 @@ private static int getYear(TemporalAccessor accessor) { if(accessor.isSupported(ChronoField.YEAR_OF_ERA)){ return accessor.get(ChronoField.YEAR_OF_ERA); } - return 1970; } diff --git a/server/src/test/java/org/elasticsearch/common/time/DateFormattersTests.java b/server/src/test/java/org/elasticsearch/common/time/DateFormattersTests.java index a3b8a732d195d..a048edcfb7091 100644 --- a/server/src/test/java/org/elasticsearch/common/time/DateFormattersTests.java +++ b/server/src/test/java/org/elasticsearch/common/time/DateFormattersTests.java @@ -65,7 +65,6 @@ public void testWeekBasedDates() { equalTo(ZonedDateTime.of(2014,12,29, 0,0,0,0,ZoneOffset.UTC))); } - // this is not in the duelling tests, because the epoch millis parser in joda time drops the milliseconds after the comma // but is able to parse the rest // as this feature is supported it also makes sense to make it exact