[ML][Transforms] fix bwc serialization with 7.3 #48021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core (:ml/Transform) |
Member
Author
|
@elasticmachine update branch |
|
can we backport this to 7.4? |
droberts195
approved these changes
Oct 15, 2019
droberts195
left a comment
droberts195
left a comment
There was a problem hiding this comment.
LGTM
Not sure how I managed to mess that up 😞
I agree it would be good to get this into 7.4.1.
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Oct 15, 2019
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Oct 15, 2019
benwtrent
added a commit
that referenced
this pull request
Oct 15, 2019
benwtrent
added a commit
that referenced
this pull request
Oct 15, 2019
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes an extra boolean that was being written to the stream. I am guessing the boolean was to handle the optional node value and just assume the node value was never written to the stream. But, this caused issues as the internal
transformStateobject reads/writes the optional node value.