SQL: fix multi full-text functions usage with aggregate functions #47444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aggregate functions with "stats" or "matrix_stats" aggregations.
Collaborator
|
Pinging @elastic/es-search (:Search/SQL) |
matriv
reviewed
Oct 2, 2019
Contributor
matriv
left a comment
matriv
left a comment
There was a problem hiding this comment.
Nice work with integration tests.
Could you please also add at least one unit test in OptimizerTests?
matriv
approved these changes
Oct 3, 2019
Contributor
matriv
left a comment
matriv
left a comment
There was a problem hiding this comment.
LGTM. Thank you!
Please don't forget to add the appropriate labels.
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full-text functions (predicates) are simple expressions (vs. named expressions) and, thus, they don't have an associated Painless script to be used in queries, nor they have results to be returned to the user (function attributes). In the specific case of replacing multiple aggregate functions (avg, min, max, skewness, variance etc) with their simplified ES aggregation (
statsormatrix_stats) any function to be replaced is searched for in the rest of the query to get replaced as well.During this search, a logical binary function - OR or AND - where full-text predicates are used is attempted to have a function attribute created for it which fails, as stated above.
The fix is to skip those functions that use full-text predicates, as they won't have a function attribute to check.
Fixes #47365.