Add enrich transport client support #46002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an enrich client, as well as a smoke test to validate the client works.
hub-cap
added
the
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-core-features |
55 tasks
martijnvg
approved these changes
Aug 27, 2019
| @@ -0,0 +1,70 @@ | |||
| package org.elasticsearch.xpack.core.enrich.client; | |||
Member
There was a problem hiding this comment.
Unapproved licenses:
00:31:21
00:31:21 /var/lib/jenkins/workspace/elastic+elasticsearch+pull-request-2/x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/enrich/client/EnrichClient.java
Contributor
Author
There was a problem hiding this comment.
and this is the quality of work i give when im paying attn to support cases instead of code :P
| public class EnrichTransportClientIT extends ESXPackSmokeClientTestCase { | ||
|
|
||
| private static void assertEqualPolicies(EnrichPolicy expectedInstance, EnrichPolicy newInstance) { | ||
| assertThat(newInstance.getType(), Matchers.equalTo(expectedInstance.getType())); |
Member
There was a problem hiding this comment.
Maybe statically import this: Matchers.equalTo
and then remove: import static org.hamcrest.CoreMatchers.equalTo;
Contributor
Author
There was a problem hiding this comment.
oh geez intelij where were u on this?
Contributor
Author
|
@elasticmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an enrich client, as well as a smoke test to validate
the client works.