Consolidate enrich list all and get by name APIs #45705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The get and list APIs are a single API in this commit. Whether requesting one named policy or all policies, a list of policies is returened. The list API code has all been removed and the GET api is what remains, which contains much of the list response code.
hub-cap
added
the
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-core-features |
55 tasks
martijnvg
approved these changes
Aug 20, 2019
| if (policy == null) { | ||
| throw new ResourceNotFoundException("Policy [{}] was not found", request.getName()); | ||
| } | ||
| policies = Collections.singletonMap(request.getName(), policy); |
Member
There was a problem hiding this comment.
Nit: maybe use Map.of()? When backporting this change, this then has to be changed back. I just prefer Map.of over Collections.singletonMap in master.
Contributor
Author
There was a problem hiding this comment.
I think this is a better solution. I forget about Map.of!
hub-cap
added a commit
that referenced
this pull request
Aug 20, 2019
The get and list APIs are a single API in this commit. Whether requesting one named policy or all policies, a list of policies is returened. The list API code has all been removed and the GET api is what remains, which contains much of the list response code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The get and list APIs are a single API in this commit. Whether
requesting one named policy or all policies, a list of policies is
returened. The list API code has all been removed and the GET api is
what remains, which contains much of the list response code.