Add result_type field to TimingStats and DatafeedTimingStats documents #44812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core |
davidkyle
approved these changes
Jul 24, 2019
Member
davidkyle
left a comment
davidkyle
left a comment
There was a problem hiding this comment.
LGTM
I left a comment about the default value of the field and making it more consistent with other usages.
.../src/main/java/org/elasticsearch/xpack/core/ml/job/process/autodetect/state/TimingStats.java
Outdated
Show resolved
Hide resolved
…AGE parameter and only set it to "true" while persisting
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Jul 25, 2019
przemekwitek
added a commit
that referenced
this pull request
Jul 25, 2019
This was referenced Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having result_type field persisted improves debuggability.