Skip to content

Updated slm API spec parameters and URL #44797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2019
Merged

Updated slm API spec parameters and URL #44797

merged 1 commit into from
Aug 1, 2019

Conversation

@delvedor
Copy link
Member

@delvedor delvedor commented Jul 24, 2019

The doc urls were not correct and slm.delete_lifecycle.json had the policy_id parameter typed wrong.

@delvedor delvedor requested review from dakrone and nik9000 July 24, 2019 09:55
dakrone
dakrone approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @delvedor

@delvedor delvedor mentioned this pull request Jul 25, 2019
Merged
nik9000
nik9000 approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 2

@delvedor
Copy link
Member Author

delvedor commented Jul 25, 2019

@dakrone not sure which labels should I use.
Furthermore, I think this should also be backported to 7.x, but I don't see it in 7.3.

@dakrone dakrone added :Data Management/ILM+SLM Index and Snapshot lifecycle management v7.4.0 labels Aug 1, 2019
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 1, 2019

Pinging @elastic/es-core-features

@dakrone dakrone added the >bug label Aug 1, 2019
@delvedor delvedor merged commit dec76d9 into elastic:master Aug 1, 2019
@delvedor delvedor deleted the fix-slm-spec branch August 1, 2019 15:23
delvedor added a commit to delvedor/elasticsearch that referenced this pull request Aug 1, 2019
@delvedor
Updated slm API spec parameters and URL (elastic#44797)
54ba2af
@delvedor delvedor mentioned this pull request Aug 1, 2019
Merged
delvedor added a commit that referenced this pull request Aug 2, 2019
@delvedor
Updated slm API spec parameters and URL (#44797) (#45102)
6b71621
@codebrain codebrain mentioned this pull request Oct 14, 2019
Closed
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dakrone dakrone dakrone approved these changes

@nik9000 nik9000 nik9000 approved these changes

Assignees

No one assigned

Labels

>bug :Data Management/ILM+SLM Index and Snapshot lifecycle management v7.4.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@delvedor @elasticmachine @dakrone @nik9000 @jakelandis