Add is_write_index column to cat.aliases #44772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aliases have had the option to set `is_write_index` since 6.4, but the cat.aliases action was never updated.
talevy
added
>bug
:Core/Infra/REST API
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
Author
|
run elasticsearch-ci/bwc |
gwbrown
approved these changes
Aug 5, 2019
Contributor
gwbrown
left a comment
gwbrown
left a comment
There was a problem hiding this comment.
Still LGTM - I don't love the duplication of the test cases, but I don't know of a better way to do it either.
Contributor
Author
|
thanks Gordon run elasticsearch-ci/bwc |
talevy
added a commit
to talevy/elasticsearch
that referenced
this pull request
Aug 21, 2019
talevy
added a commit
that referenced
this pull request
Aug 21, 2019
talevy
added a commit
that referenced
this pull request
Aug 21, 2019
* Add is_write_index column to cat.aliases (#44772) Aliases have had the option to set `is_write_index` since 6.4, but the cat.aliases action was never updated. * correct version bounds to 7.4
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aliases have had the option to set
is_write_indexsince 6.4,but the cat.aliases action was never updated.
example: